algod: Delete deprecated cost field in dyrun response and mapping field in sourcemap#4875
Merged
michaeldiamant merged 4 commits intoalgorand:masterfrom Dec 8, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4875 +/- ##
==========================================
- Coverage 53.94% 53.93% -0.02%
==========================================
Files 425 425
Lines 53256 53251 -5
==========================================
- Hits 28731 28722 -9
Misses 22265 22265
- Partials 2260 2264 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algochoi
commented
Dec 7, 2022
algochoi
changed the title
michaeldiamant
previously approved these changes
Dec 8, 2022
Contributor
|
oh boy, you should probably merge master to resolve the conflict in |
Contributor
Author
|
Thanks for the bump! Re-requested for review after merging |
ahangsu
approved these changes
Dec 8, 2022
This was
linked to
issues
Dec 8, 2022
michaeldiamant
approved these changes
Dec 8, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR deletes deprecated fields in the v2 API:
costfield inDryrunTxnResultmappingfield fromsourcemapobjectPart of algorand/algorand-sdk-testing#201
Test Plan
CI Tests